Skip to content

Fixed changed log syntax to support PyPI packaging. #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

Fixed changed log syntax to support PyPI packaging. #1499

merged 2 commits into from
Jun 20, 2025

Conversation

tim-schilling
Copy link
Member

This resolves the packaging problem for 3.10.0 https://github.com/django-commons/django-simple-history/actions/runs/15783383565/job/44497104163

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@tim-schilling tim-schilling requested a review from ddabble June 20, 2025 17:24
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ddabble
ddabble reviewed Jun 20, 2025
View reviewed changes
ddabble
ddabble approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😅

@tim-schilling tim-schilling merged commit dc56984 into master Jun 20, 2025
43 checks passed
@tim-schilling tim-schilling deleted the fix-changelog branch June 20, 2025 20:18
@tim-schilling
Copy link
Member Author

Alright, looks like the release this time was successful. Thank you for your patience @ddabble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddabble ddabble ddabble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-schilling @ddabble